Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use 'main' for buildkit image tag. #398

Merged
merged 1 commit into from
Jun 12, 2024
Merged

Conversation

alxp
Copy link
Contributor

@alxp alxp commented Jun 7, 2024

What does this pull request do?

Resolves #397 . Now BuildKit versions don't require a manual update to ISLE-DC's developpment branch to get latest images.

How should this be tested

  1. Run make starter_dev from a clean instance of ISLE-DC.
  2. Observe that the images that get pulled are the newest ones from https://github.com/Islandora-Devops/isle-buildkit/tags

@aOelschlager aOelschlager self-requested a review June 12, 2024 17:54
Copy link
Contributor

@aOelschlager aOelschlager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@aOelschlager aOelschlager merged commit 695fb92 into development Jun 12, 2024
1 check passed
@aOelschlager aOelschlager deleted the 397-use-main-tag branch June 12, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Point 'development' branch to ISLE-BuildKit 'main' tag
2 participants